Keep an installed runtime whose archive is unchanged across releases - #81
Merged
Conversation
The runtime receipt was compared by release URL, so every release re-downloaded and unpacked the 84 MB runtime archive even when it was byte-identical. When the authenticated archive digest of the new release matches the installed receipt and the executable is intact, the launcher now adopts the new release identity and keeps the runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every release re-downloaded and unpacked the runtime archive because the receipt was compared by release URL first. The archive has been the same bytes since v0.0.9.
When the new release's authenticated SHA256SUMS names the same archive digest the installed receipt carries and the executable is intact, the launcher rewrites the receipt with the new release identity and keeps the runtime. A different digest still goes through the normal update with rollback. Tested in the VM by serving the same assets under a new URL: the log shows "runtime archive unchanged ... kept the installed runtime", the asset log shows no archive request, and the receipt carries the new release afterwards.